Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace listWeek with listMonth #514

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Replace listWeek with listMonth #514

wants to merge 6 commits into from
+10 −7

Conversation

felixhahnweilheim
Copy link
Contributor

@felixhahnweilheim felixhahnweilheim commented Dec 14, 2024 •
edited
Loading

solves #463 by replacing listWeek with listYear listMonth.

@Semir1212 mentioned two options:

  • replacing listWeek with listYear listMonth (what I did)
  • adding listYear (would also be very simple to implement, we just not a wording to differentiate the two, like "List (Year)" and "List (Week)"

I think ideally this should be somehow configurable as there are networks with just a few events and those with a lot.

But I would like to bring this issue further because the listWeek view is not practical in my case.
Actually there would be also listMonth which could also be interesting.

With this PR I just want to show how easy this is to solve as the different view modes are already available.

@luke-
Copy link
Contributor

luke- commented Dec 16, 2024

@felixhahnweilheim Thanks for the example and PR!

@Semir1212 @felixhahnweilheim An extra config option for this is perhaps a bit much.
However, I am also unsure which view we should offer here.
Maybe we could find a dynamic solution for this? Depending on the number of entries, weekly/monthly/yearly?
Otherwise, I would opt for monthly as an in-between option.

@felixhahnweilheim felixhahnweilheim changed the title Replace listWeek with listYear Replace listWeek with listMonth Dec 16, 2024
@felixhahnweilheim
Copy link
Contributor Author

I updated the PR to use listMonth. I agree this is a good in between option.
I also updated that in the default view mode only listMonth is available (still called "List").
So the available default view modes are the same as the buttons shown in the FullCalendar view.

Old settings (listWeek, listYear) are handled in the initSettings method. This way we don't need a migration.

Maybe we could find a dynamic solution for this? Depending on the number of entries, weekly/monthly/yearly?

This also sounds interesting. However users might not understand what is happening then. And it is a bit more effort to implement. So I think listMonth is a good solution. (Unless someone wants to spend the time code a good dynamic solution.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixhahnweilheim @luke-